edoc: fix uris for link references to otp on-line documentation - #11433
edoc: fix uris for link references to otp on-line documentation#11433vances wants to merge 3 commits into
Conversation
CT Test Results 2 files 13 suites 3m 16s ⏱️ Results for commit 27f3450. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
kikofernandez
added
the
testing
| URI1 = uri_string:parse(Href1#xmlAttribute.value), | ||
| "www.erlang.org" = maps:get(host, URI1), | ||
| "/doc/apps/kernel/application.html" = maps:get(path, URI1), | ||
| % "start/1" = maps:get(fragment, URI1), |
There was a problem hiding this comment.
is this relevant? If not, please remove it
There was a problem hiding this comment.
It is relevant. The fix is not complete yet. It will be nearer to complete when we can remove the comment.
| URI2 = uri_string:parse(Href2#xmlAttribute.value), | ||
| "www.erlang.org" = maps:get(host, URI2), | ||
| "/doc/apps/kernel/application.html" = maps:get(path, URI2). | ||
| % "start/1" = maps:get(fragment, URI2). |
There was a problem hiding this comment.
same here, if the comment is not relevant, it can be removed
There was a problem hiding this comment.
It is relevant. The fix is not complete yet. It will be nearer to complete when we can remove the comment.
3 participants
Fix #11405
Changes
?APP_DEFAULTto match base URI for OTP on-line documentation.Special cases application path construction when base is
?APP_DEFAULT.Does NOT yet address difference in fragment part of URIs (i.e.
#start/1not#start-1).